Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow http in datafusion-cli http object store #13626

Merged
merged 3 commits into from
Dec 4, 2024
Merged

allow http in datafusion-cli http object store #13626

merged 3 commits into from
Dec 4, 2024

Conversation

adriangb
Copy link
Contributor

@adriangb adriangb commented Dec 3, 2024

Unlike S3 or other object stores you have to explicitly give http or https as the protocol. It makes sense to me that if you're specifying http explicitly it's okay to make the insecure connection. This would be quite useful for local testing.

alamb
alamb approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adriangb -- this makes sense to me

@jonahgao jonahgao merged commit c62ab39 into apache:main Dec 4, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adriangb @alamb @jonahgao