Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor]: Introduce IndexSet and IndexMap aliases. #13611

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

akurmustafa
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

This Pr is similar to PR. It replaces all usages of indexmap::IndexSet and indexmap::IndexMap with datafusion_common::IndexSet and datafusion_common::IndexMap to enforce consistency across DataFusion.

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added sql SQL Planner logical-expr Logical plan and expressions physical-expr Physical Expressions optimizer Optimizer rules common Related to common crate labels Nov 30, 2024
Copy link
Contributor

@jayzhan211 jayzhan211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@findepi
Copy link
Member

findepi commented Dec 2, 2024

It replaces all usages of indexmap::IndexSet and indexmap::IndexMap with datafusion_common::IndexSet and datafusion_common::IndexMap to enforce consistency across DataFusion.

if some new code uses indexmap::IndexSet directly, will it cause compile-time or CI failure?

@akurmustafa
Copy link
Contributor Author

It replaces all usages of indexmap::IndexSet and indexmap::IndexMap with datafusion_common::IndexSet and datafusion_common::IndexMap to enforce consistency across DataFusion.

if some new code uses indexmap::IndexSet directly, will it cause compile-time or CI failure?

Actually, neither as far as I know. This is just a name alias.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like an improvement to me, though as @findepi notes it would be even better with more docs / automatic checking / guidance for developers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Related to common crate logical-expr Logical plan and expressions optimizer Optimizer rules physical-expr Physical Expressions sql SQL Planner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants