Minor: Simplify IdentTaker
#13609
Merged
Minor: Simplify IdentTaker
#13609
+31
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Nov 30, 2024
| @@ -622,21 +622,37 @@ pub fn object_name_to_table_reference( | |||
| idents_to_table_reference(idents, enable_normalization) | |||
| } | |||
|
|
|||
| struct IdentTaker(Vec<Ident>); | |||
| struct IdentTaker { | |||
| normalizer: IdentNormalizer, | |||
There was a problem hiding this comment.
the point of the PR is to move normalizer into IdentTaker so it isn't created again on each row
jonahgao
approved these changes
Nov 30, 2024
| } | ||
|
|
||
| /// Returns the number of remaining identifiers | ||
| fn len(&self) -> usize { |
Weijun-H
approved these changes
Dec 1, 2024
|
Thanks @jonahgao for reviewing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #13605
Rationale for this change
As suggested by @jonahgao on https://github.com/apache/datafusion/pull/13605/files#r1863695929
What changes are included in this PR?
Are these changes tested?
Yes, by CI
Are there any user-facing changes?
No, these are all internal apis