remove dep

apache · Nov 22, 2024 · f997f1c · f997f1c
1 parent 51140b8
commit f997f1c
Show file tree

Hide file tree

Showing 12 changed files with 18 additions and 18 deletions.
diff --git a/datafusion/functions/benches/concat.rs b/datafusion/functions/benches/concat.rs
@@ -39,7 +39,7 @@ fn criterion_benchmark(c: &mut Criterion) {
         let mut group = c.benchmark_group("concat function");
         group.bench_function(BenchmarkId::new("concat", size), |b| {
             b.iter(|| {
-                #[allow(deprecated)] // TODO use invoke_with_args
+                // TODO use invoke_with_args
                 criterion::black_box(concat().invoke_batch(&args, size).unwrap())
             })
         });

diff --git a/datafusion/functions/benches/cot.rs b/datafusion/functions/benches/cot.rs
@@ -34,15 +34,15 @@ fn criterion_benchmark(c: &mut Criterion) {
         let f32_args = vec![ColumnarValue::Array(f32_array)];
         c.bench_function(&format!("cot f32 array: {}", size), |b| {
             b.iter(|| {
-                #[allow(deprecated)] // TODO use invoke_with_args
+                // TODO use invoke_with_args
                 black_box(cot_fn.invoke_batch(&f32_args, size).unwrap())
             })
         });
         let f64_array = Arc::new(create_primitive_array::<Float64Type>(size, 0.2));
         let f64_args = vec![ColumnarValue::Array(f64_array)];
         c.bench_function(&format!("cot f64 array: {}", size), |b| {
             b.iter(|| {
-                #[allow(deprecated)] // TODO use invoke_with_args
+                // TODO use invoke_with_args
                 black_box(cot_fn.invoke_batch(&f64_args, size).unwrap())
             })
         });

diff --git a/datafusion/functions/benches/date_bin.rs b/datafusion/functions/benches/date_bin.rs
@@ -47,7 +47,7 @@ fn criterion_benchmark(c: &mut Criterion) {
         let udf = date_bin();
 
         b.iter(|| {
-            #[allow(deprecated)] // TODO use invoke_with_args
+            // TODO use invoke_with_args
             black_box(
                 udf.invoke_batch(&[interval.clone(), timestamps.clone()], batch_len)
                     .expect("date_bin should work on valid values"),

diff --git a/datafusion/functions/benches/isnan.rs b/datafusion/functions/benches/isnan.rs
@@ -33,15 +33,15 @@ fn criterion_benchmark(c: &mut Criterion) {
         let f32_args = vec![ColumnarValue::Array(f32_array)];
         c.bench_function(&format!("isnan f32 array: {}", size), |b| {
             b.iter(|| {
-                #[allow(deprecated)] // TODO use invoke_with_args
+                // TODO use invoke_with_args
                 black_box(isnan.invoke_batch(&f32_args, size).unwrap())
             })
         });
         let f64_array = Arc::new(create_primitive_array::<Float64Type>(size, 0.2));
         let f64_args = vec![ColumnarValue::Array(f64_array)];
         c.bench_function(&format!("isnan f64 array: {}", size), |b| {
             b.iter(|| {
-                #[allow(deprecated)] // TODO use invoke_with_args
+                // TODO use invoke_with_args
                 black_box(isnan.invoke_batch(&f64_args, size).unwrap())
             })
         });

diff --git a/datafusion/functions/benches/ltrim.rs b/datafusion/functions/benches/ltrim.rs
@@ -141,7 +141,7 @@ fn run_with_string_type<M: Measurement>(
         ),
         |b| {
             b.iter(|| {
-                #[allow(deprecated)] // TODO use invoke_with_args
+                // TODO use invoke_with_args
                 black_box(ltrim.invoke_batch(&args, size))
             })
         },

diff --git a/datafusion/functions/benches/nullif.rs b/datafusion/functions/benches/nullif.rs
@@ -34,7 +34,7 @@ fn criterion_benchmark(c: &mut Criterion) {
         ];
         c.bench_function(&format!("nullif scalar array: {}", size), |b| {
             b.iter(|| {
-                #[allow(deprecated)] // TODO use invoke_with_args
+                // TODO use invoke_with_args
                 black_box(nullif.invoke_batch(&args, size).unwrap())
             })
         });

diff --git a/datafusion/functions/benches/signum.rs b/datafusion/functions/benches/signum.rs
@@ -44,7 +44,7 @@ fn criterion_benchmark(c: &mut Criterion) {
         let f64_args = vec![ColumnarValue::Array(f64_array)];
         c.bench_function(&format!("signum f64 array: {}", size), |b| {
             b.iter(|| {
-                #[allow(deprecated)] // TODO use invoke_with_args
+                // TODO use invoke_with_args
                 black_box(signum.invoke_batch(&f64_args, batch_len).unwrap())
             })
         });

diff --git a/datafusion/functions/benches/substr.rs b/datafusion/functions/benches/substr.rs
@@ -182,7 +182,7 @@ fn criterion_benchmark(c: &mut Criterion) {
             ),
             |b| {
                 b.iter(|| {
-                    #[allow(deprecated)] // TODO use invoke_with_args
+                    // TODO use invoke_with_args
                     black_box(substr.invoke_batch(&args, size))
                 })
             },
@@ -205,7 +205,7 @@ fn criterion_benchmark(c: &mut Criterion) {
             ),
             |b| {
                 b.iter(|| {
-                    #[allow(deprecated)] // TODO use invoke_with_args
+                    // TODO use invoke_with_args
                     black_box(substr.invoke_batch(&args, size))
                 })
             },

diff --git a/datafusion/functions/benches/to_char.rs b/datafusion/functions/benches/to_char.rs
@@ -88,7 +88,7 @@ fn criterion_benchmark(c: &mut Criterion) {
         let patterns = ColumnarValue::Array(Arc::new(patterns(&mut rng)) as ArrayRef);
 
         b.iter(|| {
-            #[allow(deprecated)] // TODO use invoke_with_args
+            // TODO use invoke_with_args
             black_box(
                 to_char()
                     .invoke_batch(&[data.clone(), patterns.clone()], batch_len)
@@ -106,7 +106,7 @@ fn criterion_benchmark(c: &mut Criterion) {
             ColumnarValue::Scalar(ScalarValue::Utf8(Some("%Y-%m-%d".to_string())));
 
         b.iter(|| {
-            #[allow(deprecated)] // TODO use invoke_with_args
+            // TODO use invoke_with_args
             black_box(
                 to_char()
                     .invoke_batch(&[data.clone(), patterns.clone()], batch_len)

diff --git a/datafusion/functions/benches/trunc.rs b/datafusion/functions/benches/trunc.rs
@@ -34,15 +34,15 @@ fn criterion_benchmark(c: &mut Criterion) {
         let f32_args = vec![ColumnarValue::Array(f32_array)];
         c.bench_function(&format!("trunc f32 array: {}", size), |b| {
             b.iter(|| {
-                #[allow(deprecated)] // TODO use invoke_with_args
+                // TODO use invoke_with_args
                 black_box(trunc.invoke_batch(&f32_args, size).unwrap())
             })
         });
         let f64_array = Arc::new(create_primitive_array::<Float64Type>(size, 0.2));
         let f64_args = vec![ColumnarValue::Array(f64_array)];
         c.bench_function(&format!("trunc f64 array: {}", size), |b| {
             b.iter(|| {
-                #[allow(deprecated)] // TODO use invoke_with_args
+                // TODO use invoke_with_args
                 black_box(trunc.invoke_batch(&f64_args, size).unwrap())
             })
         });

diff --git a/datafusion/functions/benches/upper.rs b/datafusion/functions/benches/upper.rs
@@ -38,7 +38,7 @@ fn criterion_benchmark(c: &mut Criterion) {
         let args = create_args(size, 32);
         c.bench_function("upper_all_values_are_ascii", |b| {
             b.iter(|| {
-                #[allow(deprecated)] // TODO use invoke_with_args
+                // TODO use invoke_with_args
                 black_box(upper.invoke_batch(&args, size))
             })
         });

diff --git a/datafusion/functions/src/datetime/from_unixtime.rs b/datafusion/functions/src/datetime/from_unixtime.rs
@@ -166,7 +166,7 @@ mod test {
     fn test_without_timezone() {
         let args = [ColumnarValue::Scalar(Int64(Some(1729900800)))];
 
-        #[allow(deprecated)] // TODO use invoke_batch
+        // TODO use invoke_with_args
         let result = FromUnixtimeFunc::new().invoke_batch(&args, 1).unwrap();
 
         match result {
@@ -186,7 +186,7 @@ mod test {
             ))),
         ];
 
-        #[allow(deprecated)] // TODO use invoke_batch
+        // TODO use invoke_with_args
         let result = FromUnixtimeFunc::new().invoke_batch(&args, 2).unwrap();
 
         match result {