Support multiple tables in TRUNCATE command
#1000
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
changed the title
TRUNCATE command parsing to cover PostgreSQL syntaxTRUNCATE command
alamb
approved these changes
Oct 20, 2023
| partitions, | ||
| table, | ||
| } => { | ||
| let table = if *table { "TABLE " } else { "" }; | ||
| write!(f, "TRUNCATE {table}{table_name}")?; | ||
| write!( |
There was a problem hiding this comment.
Perhaps you can use display_comma_separated here instead of making a a new Vec via join
|
Converting to draft as CI is failing. Please mark as ready for review when it is |
|
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
truncatecommand can accept a list of tables (as per the documentation: https://www.postgresql.org/docs/current/sql-truncate.html). This PR fixes the current limitation that only one table can be used in theTRUNCATEcommand.