Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Snappy to 1.2.1 #21

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Upgrade Snappy to 1.2.1 #21

wants to merge 2 commits into from

Conversation

big-r81
Copy link
Contributor

@big-r81 big-r81 commented Nov 20, 2024

No description provided.

@big-r81 big-r81 mentioned this pull request Nov 20, 2024
@dch
Copy link

dch commented Nov 22, 2024

FWIW I can't compile this at all on my ❄️ ☔ FreeBSD 15.0-CURRENT amd64 with OTP25/26/27. There's that annoying erl_interface error during linking:

dch@wintermute /p/c/snappy> rebar compile
==> snappy (compile)
Compiled src/snappy.erl
Compiling c_src/snappy_nif.cc
Compiling c_src/snappy/snappy-sinksource.cc
Compiling c_src/snappy/snappy-stubs-internal.cc
Compiling c_src/snappy/snappy.cc
ld: error: unable to find library -lerl_interface
cc: error: linker command failed with exit code 1 (use -v to see invocation)
ERROR: sh(cc c_src/snappy_nif.o c_src/snappy/snappy-sinksource.o c_src/snappy/snappy-stubs-internal.o c_src/snappy/snappy.o  -lstdc++ -shared  -L"/usr/local/lib/erlang27/lib/erl_interface-5.5.2/lib" -lerl_interface -lei -o priv/snappy_nif.so)
failed with return code 1 and the following output:
ld: error: unable to find library -lerl_interface
cc: error: linker command failed with exit code 1 (use -v to see invocation)

AFAICT its superfluous since a while, but I can't see where it is coming from.

https://github.com/skunkwerks/snappy-erlang-nif/tree/feature/snappy-1.2.1 has your c_src/snappy and uses rebar3 + davisp's enc.

@big-r81
Copy link
Contributor Author

big-r81 commented Nov 23, 2024

Do you use rebar2 or rebar3? In the Makefile, we use rebar2 in CouchDB.

- requires setting `-O3` in env vars if required
- improve gitignores
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants