Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-9841 - Allow iOS statusbar to animate hide/show #123

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

timbru31
Copy link
Member

@timbru31 timbru31 commented Jan 29, 2019

Platforms affected

  • iOS

What does this PR do?

What testing has been done on this change?

  • manual testing with iOS Simulator

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@janpio - I'm not sure how Apache handles these cases. I've not modified the original conflict just did a clean git merge master - should I squash the change and/or fix the commit message? It's not in the required format I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants