-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example configuration on how to hide splash screen on startup on iOS #121
base: master
Are you sure you want to change the base?
Conversation
Extend tutorial for hiding at startup. One does not need to directly change Xcode project to hide splash screen. It can be made through config.xml
Could you please take a look at my comments and suggestions @milseg? Thanks. |
Co-Authored-By: Jan Piotrowski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with suggested change
Shouldn't it be |
@FlorentMasson If my memory serves right, both can use XML but only Re-adding a plugin is always required if changes are made to the plugin variables and platform re-adding is always required when changing other values. If those necessities are not documented then we should improve it over at https://github.com/apache/cordova-docs. |
Co-authored-by: Niklas Merz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I don't think we should be recommending this on the plugin docs as we do now, nor adding this change. |
We are using the same two properties in production without any issues - and are able to hide/show the status bar programmatically. Maybe I'm mistaken, too - Apple's docs are always terrible. |
yeah, if not using |
Extend tutorial for hiding at startup. One does not need to directly change Xcode project to hide splash screen. It can be made through config.xml
Platforms affected
What does this PR do?
What testing has been done on this change?
Checklist