Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Navigator.connection types #144

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ajuanjojjj
Copy link

Platforms affected

All typescript projects

Motivation and Context

Fixes "Wrong typing for Connection" (#143)

Description

Adds dispatchEvent() to Navigator.connection
Change Connection.type from string to ConnectionType

Testing

Compilating after the changes

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above
  • I've updated the documentation if necessary

@ajuanjojjj
Copy link
Author

I tried to run the tests with npm test, but seems like there's no .eslintrc file, so eslint fails.

However, given that this is a TypeScript only issue, I'm not sure it'd do anything, even if the fix introduces problems, unless said file included configuration for the eslint-typescript plugin. Nevertheless, i'd be happy to run further tests if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant