Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
all
Motivation and Context
We want to do a new major version which drops the telemetry stuff, this is some other cleanup that should also be included in that next major.
Description
loud-rejection
dependency because it's now default NodeJS behaviourNote that we're bumping the NodeJS engine requirement, but the lower level modules (cordova-common, cordova-lib, etc.) have not had major versions published which bump that requirement yet. However, doing the bump here means that we should be able to pull in those major versions when they do happen, provided the visible API breaking change (to cordova-cli's perspective) is the NodeJS bump.
Testing
All unit tests pass
Checklist