Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Prepare for next major #642

Merged
merged 5 commits into from
Jun 18, 2024
Merged

chore!: Prepare for next major #642

merged 5 commits into from
Jun 18, 2024

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Jun 17, 2024

Platforms affected

all

Motivation and Context

We want to do a new major version which drops the telemetry stuff, this is some other cleanup that should also be included in that next major.

Description

  • Updated package version to 13.0.0-dev
  • Updated dependencies to latest compatible versions
  • Removed the loud-rejection dependency because it's now default NodeJS behaviour
  • Bumped the NodeJS engine requirement to Node 18

Note that we're bumping the NodeJS engine requirement, but the lower level modules (cordova-common, cordova-lib, etc.) have not had major versions published which bump that requirement yet. However, doing the bump here means that we should be able to pull in those major versions when they do happen, provided the visible API breaking change (to cordova-cli's perspective) is the NodeJS bump.

Testing

All unit tests pass

Checklist

  • I've run the tests to see all new and existing tests pass

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.53%. Comparing base (71a5c89) to head (2d4efdf).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #642   +/-   ##
=======================================
  Coverage   65.53%   65.53%           
=======================================
  Files           3        3           
  Lines         235      235           
=======================================
  Hits          154      154           
  Misses         81       81           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dpogue
Copy link
Member Author

dpogue commented Jun 17, 2024

I didn't have time to dig through all the outdated dependencies and see if any can be bumped. Just did the easy stuff here.
I suspect things like nyc probably can be updated, and can be handled in a follow-up PR specifically for those dependencies.

@dpogue dpogue merged commit 5f6f3e3 into apache:master Jun 18, 2024
10 checks passed
@dpogue dpogue deleted the next-prep branch June 18, 2024 05:36
@dpogue dpogue added this to the 13.0.0 milestone Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants