Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-4102: [C++] Remove boost::shared_array #3273

Merged
merged 3 commits into from
Dec 29, 2024
Merged

Conversation

wgtmac
Copy link
Member

@wgtmac wgtmac commented Dec 27, 2024

What is the purpose of the change

Remove boost::shared_array.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Documentation

  • Does this pull request introduce a new feature? no

@github-actions github-actions bot added the C++ Pull Requests for C++ binding label Dec 27, 2024
@thiru-mg
Copy link
Contributor

@wgtmac, after I removed the conflict with your other PR, some compilation error has appeared. Can you please fix it and update this PR. Thank you

@wgtmac
Copy link
Member Author

wgtmac commented Dec 29, 2024

Fixed. Thanks @thiru-mg!

@Fokko
Copy link
Contributor

Fokko commented Dec 29, 2024

Thanks for cleaning this up @wgtmac and thanks for the review @thiru-mg 🙌 Let's move this forward 🚀

@Fokko Fokko merged commit 07fbc01 into apache:main Dec 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ Pull Requests for C++ binding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants