AVRO-4076: [java] Parse Fields before adding to the context. #3255
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request fixes the issue identified by AVRO-4076.
This is potentially not the best way to do this but I think it at least demonstrates what I think the issue is.
In Schema, we put the result into the context, (ultimately leading to the throw). But we haven't loaded the fields at that point, causing the equality check to fail even if the schemas do match.
Unfortunately I had to change the equals in
Protocol.java
in order to get the tests to pass. The order of schemas returned byParseContext.resolveAllSchemas
has slightly changed. I'm not sure that the order matters, but if I change ParseContext.resolveAllSchemas to return an unordered collection I get failures in TestIdlReader.runTests.Verifying this change
This change added tests and can be verified as follows:
TestSchema::testParseMultipleFile
has been updated to include the redefined Schema scenario.Documentation