[AVRO-4085][C++] Fix file size extraction error on windows platform #3229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkmkme
approved these changes
Oct 29, 2024
|
Thank you, @glywk ! |
thiru-mg
pushed a commit
that referenced
this pull request
Dec 24, 2024
…#3230) * AVRO-4086: Fix missing data file reader close handle on windows * AVRO-4085: Fix file size extraction error on windows platform (#3229) * Use Ubuntu 24.04 for the Interop tests to be able to use newer Python Python 3.12 needs `--break-system-packages` ``` Run python3 -m pip install --break-system-packages --upgrade pip setuptools tox python3 -m pip install --break-system-packages --upgrade pip setuptools tox python3 -m pip install --break-system-packages python-snappy zstandard shell: /usr/bin/bash -e {0} Usage: /usr/bin/python3 -m pip install [options] <requirement specifier> [package-index-options] ... /usr/bin/python3 -m pip install [options] -r <requirements file> [package-index-options] ... /usr/bin/python3 -m pip install [options] [-e] <vcs project url> ... /usr/bin/python3 -m pip install [options] [-e] <local project path> ... /usr/bin/python3 -m pip install [options] <archive url/path> ... ``` Signed-off-by: Martin Tzvetanov Grigorov <[email protected]> * AVRO-4086: Fix missing data file reader close handle on windows * AVRO-4086: Simplify closing stream reader * Fix the name of the CI runner --------- Signed-off-by: Martin Tzvetanov Grigorov <[email protected]> Co-authored-by: Martin Tzvetanov Grigorov <[email protected]> Co-authored-by: Martin Grigorov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request fix windows test failure, fixing AVRO-4085
Verifying this change
This change is a trivial rework / code cleanup without that fixing test coverage.
Documentation