Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: AVRO-3986: [csharp] - Plain JSON encoding for Apache Avro #2888

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Added JSON root records feature.

542a874
Select commit
Loading
Failed to load commit list.
Draft

WIP: AVRO-3986: [csharp] - Plain JSON encoding for Apache Avro #2888

Added JSON root records feature.
542a874
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL completed Aug 23, 2024 in 5s

3 configurations not found

Warning: Code scanning may not have found all the alerts introduced by this pull request, because 3 configurations present on refs/heads/main were not found:

Actions workflow (codeql-py-analysis.yml)

  • ❓  .github/workflows/codeql-py-analysis.yml:analyze/language:python

Actions workflow (codeql-js-analysis.yml)

  • ❓  .github/workflows/codeql-js-analysis.yml:analyze/language:javascript

Actions workflow (codeql-java-analysis.yml)

  • ❓  .github/workflows/codeql-java-analysis.yml:analyze/language:java

New alerts in code changed by this pull request

  • 16 warnings
  • 6 notes

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 804 in lang/csharp/src/apache/main/IO/JsonDecoder.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless assignment to local variable Warning

This assignment to
fa
Loading
is useless, since its value is never read.

Check warning on line 806 in lang/csharp/src/apache/main/IO/JsonDecoder.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless assignment to local variable Warning

This assignment to
ia
Loading
is useless, since its value is never read.

Check notice on line 834 in lang/csharp/src/apache/main/IO/JsonDecoder.cs

See this annotation in the file changed.

Code scanning / CodeQL

Complex condition Note

Complex condition: too many logical operations in this expression.

Check notice on line 871 in lang/csharp/src/apache/main/IO/JsonDecoder.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missed ternary opportunity Note

Both branches of this 'if' statement return - consider using '?' to express intent better.

Check notice on line 887 in lang/csharp/src/apache/main/IO/JsonDecoder.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missed ternary opportunity Note

Both branches of this 'if' statement return - consider using '?' to express intent better.

Check notice on line 1066 in lang/csharp/src/apache/main/IO/JsonDecoder.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missed ternary opportunity Note

Both branches of this 'if' statement write to the same variable - consider using '?' to express intent better.

Check notice on line 138 in lang/csharp/src/apache/main/IO/Parsing/JsonGrammarGenerator.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missed ternary opportunity Note

Both branches of this 'if' statement return - consider using '?' to express intent better.

Check warning on line 207 in lang/csharp/src/apache/main/Schema/RecordSchema.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless assignment to local variable Warning

This assignment to
altnames
Loading
is useless, since its value is never read.

Check warning on line 59 in lang/csharp/src/apache/main/Util/Date.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless upcast Warning

There is no need to upcast from
DateTime
Loading
to
Object
Loading
- the conversion can be done implicitly.

Check warning on line 67 in lang/csharp/src/apache/main/Util/Date.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless upcast Warning

There is no need to upcast from
String
Loading
to
Object
Loading
- the conversion can be done implicitly.

Check warning on line 88 in lang/csharp/src/apache/main/Util/Decimal.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless upcast Warning

There is no need to upcast from
Byte[]
Loading
to
Object
Loading
- the conversion can be done implicitly.

Check warning on line 92 in lang/csharp/src/apache/main/Util/Decimal.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless upcast Warning

There is no need to upcast from
GenericFixed
Loading
to
Object
Loading
- the conversion can be done implicitly.

Check warning on line 66 in lang/csharp/src/apache/main/Util/LocalTimestampMicrosecond.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless upcast Warning

There is no need to upcast from
DateTime
Loading
to
Object
Loading
- the conversion can be done implicitly.

Check warning on line 70 in lang/csharp/src/apache/main/Util/LocalTimestampMicrosecond.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless upcast Warning

There is no need to upcast from
String
Loading
to
Object
Loading
- the conversion can be done implicitly.

Check warning on line 65 in lang/csharp/src/apache/main/Util/LocalTimestampMillisecond.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless upcast Warning

There is no need to upcast from
DateTime
Loading
to
Object
Loading
- the conversion can be done implicitly.

Check warning on line 69 in lang/csharp/src/apache/main/Util/LocalTimestampMillisecond.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless upcast Warning

There is no need to upcast from
String
Loading
to
Object
Loading
- the conversion can be done implicitly.

Check warning on line 76 in lang/csharp/src/apache/main/Util/TimeMicrosecond.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless upcast Warning

There is no need to upcast from
String
Loading
to
Object
Loading
- the conversion can be done implicitly.

Check warning on line 72 in lang/csharp/src/apache/main/Util/TimeMillisecond.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless upcast Warning

There is no need to upcast from
String
Loading
to
Object
Loading
- the conversion can be done implicitly.

Check warning on line 66 in lang/csharp/src/apache/main/Util/TimestampMicrosecond.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless upcast Warning

There is no need to upcast from
String
Loading
to
Object
Loading
- the conversion can be done implicitly.

Check warning on line 61 in lang/csharp/src/apache/main/Util/TimestampMillisecond.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless upcast Warning

There is no need to upcast from
DateTime
Loading
to
Object
Loading
- the conversion can be done implicitly.

Check warning on line 50 in lang/csharp/src/apache/main/Util/Uuid.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless upcast Warning

There is no need to upcast from
String
Loading
to
Object
Loading
- the conversion can be done implicitly.

Check notice on line 525 in lang/csharp/src/apache/test/IO/JsonCodecTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missed opportunity to use Select Note test

This foreach loop immediately
maps its iteration variable to another variable
Loading
- consider mapping the sequence explicitly using '.Select(...)'.