AVRO-3677: Add SchemaFormatter #2885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a SchemaFormatter interface and factory method to format schemas to different formats by name. The initial implementation supports JSON (both inline and pretty printed), and the parsing canonical form.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
lang/java/avro/src/main/java/org/apache/avro/JsonSchemaFormatter.java
Dismissed
Show dismissed
Hide dismissed
lang/java/idl/src/main/java/org/apache/avro/util/IdlUtils.java
Dismissed
Show dismissed
Hide dismissed
lang/java/idl/src/test/java/org/apache/avro/util/IdlUtilsTest.java
Dismissed
Show dismissed
Hide dismissed
lang/java/idl/src/test/java/org/apache/avro/util/IdlUtilsTest.java
Dismissed
Show dismissed
Hide dismissed
Fokko
approved these changes
May 5, 2024
lang/java/avro/src/main/java/org/apache/avro/JsonSchemaFormatterFactory.java
Show resolved
Hide resolved
lang/java/avro/src/main/java/org/apache/avro/JsonSchemaFormatterFactory.java
Show resolved
Hide resolved
lang/java/idl/src/main/java/org/apache/avro/idl/IdlSchemaParser.java
Outdated
Show resolved
Hide resolved
RanbirK
pushed a commit
to RanbirK/avro
that referenced
this pull request
May 13, 2024
* AVRO-3677: Introduce Named Schema Formatters Adds a SchemaFormatter interface and factory method to format schemas to different formats by name. The initial implementation supports JSON (both inline and pretty printed), the parsing canonical form, and the IDL format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Add a
SchemaFormatter, complementing the recently addedSchemaParser.Verifying this change
This change added tests and can be verified as follows:
IdlSchemaParserDocumentation
no)not applicable/docs/ JavaDocs /not documented)