Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-3969: Use WriteMapStart in WriteMap #2836

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

zcsizmadia
Copy link
Contributor

What is the purpose of the change

Fixing AVRO-3969

Verifying this change

(Please pick one of the following options)

This change added tests and can be verified as follows:

  • Extended JsonEncoder tests

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@github-actions github-actions bot added the C# label Apr 4, 2024
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, great catch @zcsizmadia

@zcsizmadia
Copy link
Contributor Author

Thanks to Dave Kliczbor for finding the issue and filing the ticket!

@zcsizmadia zcsizmadia merged commit ee647a6 into apache:main Apr 5, 2024
9 checks passed
@zcsizmadia zcsizmadia deleted the avro-3969-fix-map-writemap branch April 5, 2024 14:15
RanbirK pushed a commit to RanbirK/avro that referenced this pull request May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants