Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Added support for installing dependencies with Conan #2787

Closed
wants to merge 1 commit into from

Conversation

mkmkme
Copy link
Contributor

@mkmkme mkmkme commented Mar 4, 2024

What is the purpose of the change

With this small change, developers of C++ bindings of Avro can build it on a machine with no boost installed.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Documentation

  • Does this pull request introduce a new feature? no
  • Although the new possible way of building is documented in README

@github-actions github-actions bot added the C++ Pull Requests for C++ binding label Mar 4, 2024
@martin-g
Copy link
Member

martin-g commented Mar 5, 2024

You need to add the license header for the new file.

@mkmkme
Copy link
Contributor Author

mkmkme commented Mar 23, 2024

Actually now I'm not entirely sure if I want this file into the repo or not 😅 I'm used to being a big conan's advocate and I still use it in situations like this.

However, with this project I started using nix-shell instead and it works just fine as well.

So I think I'll close this PR for now. If needed, I'll easily reintroduce either conanfile, or nix-shell file, or any other alternative to it.

@mkmkme mkmkme closed this Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ Pull Requests for C++ binding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants