AVRO-3953: Prefixing enum member identifiers instead of throwing

[clemensv]

AVRO-3953

What is the purpose of the change

This eliminates a blocking issue where code-gen throws while generating code for this enum:

{
    "type": "enum",
    "symbols": [
        "string",
        "integer",
        "float",
        "boolean",
        "list",
        "dict",
        "regex"
    ],
    "name": "type",
    "namespace": "com.example"
}

Verifying this change

This change is a trivial rework without any test coverage. It eliminates an apparent misunderstanding of C# syntax. The above now correctly yields

public enum type
{
		@string,
		integer,
		@float,
		boolean,
		list,
		dict,
		regex,
}

Documentation

• Does this pull request introduce a new feature? no
• If yes, how is the feature documented? not applicable

[zcsizmadia]

Thanks for the PR! Could you add unit tests as well plz?

[KalleOlaviNiemitalo]

AFAICT, the C# CodeDom provider itself escapes CodeMemberField.Name if it conflicts with a keyword or starts with a double underscore. In the Microsoft.CSharp.CSharpCodeGenerator class, the GenerateField method calls OutputIdentifier, which calls CreateEscapedIdentifier.

[clemensv]

@KalleOlaviNiemitalo You are correct. I removed the local check.

@zcsizmadia Overall coverage is fairly light, but I added the test.

[martin-g]

@zcsizmadia The Jira issue is still opened.

[zcsizmadia]

@zcsizmadia The Jira issue is still opened.

I dont seem to have the right to close that ticket. @clemensv Could you close the JIRA ticket plz?