AVRO-2825: [csharp] Resolve: C# Logical Types throw exception on unkn… #2751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-g
previously requested changes
Feb 21, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
resolved all identified issues in new PR |
martin-g
reviewed
Feb 22, 2024
|
We need a C# developer/user to review the changes. |
|
Is there something I need to do to allow this PR to move forward? |
| /// </summary> | ||
| /// <param name="nullible">A flag indicating whether it should be nullible.</param> | ||
| /// <returns>Type.</returns> | ||
| public override Type GetCSharpType(bool nullible) |
There was a problem hiding this comment.
perhaps you meant nullable instead of nullible?
There was a problem hiding this comment.
I agree with your comment but that name pre-existed in many files in this codebase so I choose to be consistent.
|
I am not sure why this still shows are changes requested, they all have been made to my knowledge. |
|
all changes made |
|
LGTM. Thanks @TomBruns! |
zcsizmadia
requested changes
Apr 10, 2024
| @@ -45,7 +45,7 @@ private LogicalTypeFactory() | |||
| { TimeMicrosecond.LogicalTypeName, new TimeMicrosecond() }, | |||
| { TimestampMillisecond.LogicalTypeName, new TimestampMillisecond() }, | |||
| { TimestampMicrosecond.LogicalTypeName, new TimestampMicrosecond() }, | |||
| { Uuid.LogicalTypeName, new Uuid() } | |||
| { Uuid.LogicalTypeName, new Uuid() }, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AVRO-2825
What is the purpose of the change
NOTE: This PR WILL change the behavior of the current nuget package. It corrects it to align with the AVRO spec.
This is a new version of PR #2741 incorporating all feedback from KalleOlaviNiemitalo
Avoid swallowing any exceptions thrown for other reasons.
Allow applications to parse a schema and read the name of the logical type from LogicalSchema.LogicalTypeName (or even LogicalType.Name) regardless of whether the library recognizes it.
Allow applications to parse a schema and serialize it back to JSON without losing the unrecognized logical types here:
LogicalSchema.LogicalType could then be null, or perhaps an instance of a new NotSupportedLogicalType class that would pass everything through without conversion. (I created a new type: UnknownLogicalType)
Verifying this change
This change is already covered by existing tests:
test > AvroGen > AvroGenSchemaTests.cs > NotSupportedSchema
test > Schema > SchemaTests.cs > TestUnknownLogical
This change added tests and can be verified as follows:
Documentation