Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-2825: [csharp] Resolve: C# Logical Types throw exception on unknown logical type #2741

Closed
wants to merge 4 commits into from

Resolve AVRO-3941 C# implementation of avrogen throws an exception if…

556cff3
Select commit
Loading
Failed to load commit list.
Closed

AVRO-2825: [csharp] Resolve: C# Logical Types throw exception on unknown logical type #2741

Resolve AVRO-3941 C# implementation of avrogen throws an exception if…
556cff3
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL completed Feb 19, 2024 in 5s

3 configurations not found

Warning: Code scanning may not have found all the alerts introduced by this pull request, because 3 configurations present on refs/heads/main were not found:

Actions workflow (codeql-java-analysis.yml)

  • ❓  .github/workflows/codeql-java-analysis.yml:analyze/language:java

Actions workflow (codeql-js-analysis.yml)

  • ❓  .github/workflows/codeql-js-analysis.yml:analyze/language:javascript

Actions workflow (codeql-py-analysis.yml)

  • ❓  .github/workflows/codeql-py-analysis.yml:analyze/language:python

New alerts in code changed by this pull request

  • 1 warning
  • 2 notes

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 201 in lang/csharp/src/apache/main/Schema/Schema.cs

See this annotation in the file changed.

Code scanning / CodeQL

Generic catch clause Note

Generic catch clause.

Check notice on line 201 in lang/csharp/src/apache/main/Schema/Schema.cs

See this annotation in the file changed.

Code scanning / CodeQL

Poor error handling: empty catch block Note

Poor error handling: empty catch block.

Check warning on line 463 in lang/csharp/src/apache/test/Util/LogicalTypeTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Cast to same type Warning test

This cast is redundant because the expression already has type Field.