Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark MemoryOutputStream as final #2550

Closed
wants to merge 1 commit into from
Closed

mark MemoryOutputStream as final #2550

wants to merge 1 commit into from

Conversation

artpaul
Copy link

@artpaul artpaul commented Oct 15, 2023

What is the purpose of the change

Fix a warning:

avro/impl/Stream.cc:129:27: warning: class with destructor marked 'final' cannot be inherited from [-Wfinal-dtor-non-final-class]
  120 | class MemoryOutputStream : public OutputStream {
      |                          final
  121 | public:
  122 |     const size_t chunkSize_;
  123 |     std::vector<uint8_t *> data_;
  124 |     size_t available_;
  125 |     size_t byteCount_;
  126 | 
  127 |     explicit MemoryOutputStream(size_t chunkSize) : chunkSize_(chunkSize),
  128 |                                                     available_(0), byteCount_(0) {}
  129 |     ~MemoryOutputStream() final {
      |                           ^
avro/impl/Stream.cc:120:7: note: mark 'avro::MemoryOutputStream' as 'final' to silence this warning
  120 | class MemoryOutputStream : public OutputStream {
      |       ^
1 warning generated.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

@github-actions github-actions bot added the C++ Pull Requests for C++ binding label Oct 15, 2023
@Fokko
Copy link
Contributor

Fokko commented Oct 16, 2023

@thiru-mg / @thiru-aqfer WDYT?

@Fokko Fokko closed this Oct 16, 2023
@Fokko Fokko reopened this Oct 16, 2023
@Fokko
Copy link
Contributor

Fokko commented Oct 16, 2023

Hit the wrong button there, sorry for that

@artpaul artpaul closed this by deleting the head repository Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ Pull Requests for C++ binding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants