-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AVRO-3852: Upgrade CI tests to Java 21 GA release #2525
Conversation
Ah oups it seems version 21 is not yet released ok we will have to wait a bit then. |
JDK 21 is available now so we should be good. PTAL @martin-g |
lang/java/build.sh
Outdated
mvn archetype:generate \ | ||
-DarchetypeGroupId=org.apache.avro \ | ||
-DarchetypeArtifactId=avro-service-archetype \ | ||
-DgroupId=org.apache.avro \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does it know which version of the archetype to use ?
I expect something like -DarchetypeArtifactVersion=1.12.0-SNAPSHOT
to be specified too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not want to do that to avoid having to update the current version on every release (usually project maintainers tend to forget that). I digged deeper and found that there is a way to do integration tests on maven archetypes so it is maybe a better solution (Avro already was doing it but it was not well configurated for modern maven standards).
https://maven.apache.org/archetype/maven-archetype-plugin/integration-test-mojo.html
I will update this in the PR
e0ade2c
to
752fa23
Compare
I fixed the archetypes integration tests which should pretty much cover the missing validation in each specific Java version. This should be good now. PTAL again @martin-g |
* AVRO-3852: Upgrade CI tests to Java 21 GA release * AVRO-3852: Fix maven archetype generation for multiple Java versions * AVRO-3852: Test with JDK 22 EA distribution * AVRO-3852: Fix maven archetype integration test
What is the purpose of the change
(For example: This pull request improves file read performance by buffering data, fixing AVRO-XXXX.)
Verifying this change
(Please pick one of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation