AVRO-3666: [JAVA] Separate parsing from Schema class #2513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opwvhk
force-pushed
the
AVRO-3666-SchemaParser-unified-parser-interface
branch
3 times, most recently
from
e5179e9 to
4d88a15
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
opwvhk
changed the title
opwvhk
force-pushed
the
AVRO-3666-SchemaParser-unified-parser-interface
branch
from
34971c0 to
e92eac8
Compare
This allows using pluggable parser implementations, allowing multiple formats to be parsed with the same code.
Includes the use of NameValidator and parsing multiple files with circular references between them.
opwvhk
force-pushed
the
AVRO-3666-SchemaParser-unified-parser-interface
branch
from
588b055 to
5b024c1
Compare
Fix the compile error by disabling the cache for the Hadoop2 build. This cannot be code related, as the other test builds succeed.
opwvhk
force-pushed
the
AVRO-3666-SchemaParser-unified-parser-interface
branch
from
5e10934 to
d74a925
Compare
clesaec
reviewed
Nov 20, 2023
clesaec
approved these changes
Nov 27, 2023
Fokko
reviewed
Dec 2, 2023
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| /* |
There was a problem hiding this comment.
There seems to be a double license here?
Fokko
reviewed
Dec 2, 2023
| Protocol protocol = idlFile.getProtocol(); | ||
| System.out.println(protocol); | ||
| Assert.assertEquals(5, protocol.getTypes().size()); | ||
| // Path testIdl = Paths.get(".", "src", "test", "idl", |
There was a problem hiding this comment.
Should we remove this test if it isn't being used?
Fokko
reviewed
Dec 2, 2023
| @@ -1,3 +1,21 @@ | |||
| /* | |||
RanbirK
pushed a commit
to RanbirK/avro
that referenced
this pull request
May 13, 2024
This allows using pluggable parser implementations, allowing multiple formats to be parsed with the same code. This includes the use of NameValidator and parsing multiple files with circular references between them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Allow using pluggable parser implementations, allowing multiple formats to be parsed with the same code.
Verifying this change
This change adds test for all added code. The change in
IDLReaderis for readability and is covered by existing tests.Question: how can I better handle the collection parameter to the
FormattedSchemaParserinterface?Documentation
This code introduces a new feature: the documentation (Getting Started with Java) now refers to the new code, and the Javadoc documents the rest.