AVRO-3859: build.sh clean fails to remove some C# files

[zcsizmadia]

What is the purpose of the change

• Make sure that build.sh clean removes all bin and obj folders (AVRO-3859)

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Documentation

• Does this pull request introduce a new feature? (no)
• If yes, how is the feature documented? (not applicable)

[zcsizmadia]

@RyanSkraba Quick fix for AVRO-3859. I followed the pattern which is already in the clean step. Personally I like using git clean -dfx for such cleanings. It deletes all untracked and unwanted files, and by honoring the .gitignore file(s).

In that case the clean step would be just a simple git clean -dxf and not multiple rm commands.

[RyanSkraba]

LGTM -- so fast! Thanks :D

I do the exact thing (git clean -fdx) but it can be a bit dangerous to put in a script during development (to distinguish between a new source file and a new compiled file). Do you know if there's a way to clean that only remove things that would otherwise be .gitignore'd?

[zcsizmadia]

git clean -dXf

Note the capital X

[RyanSkraba]

🤯 Today I learned!! Thanks for this! https://issues.apache.org/jira/browse/AVRO-3864