Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-2254: [java] fix unresolved schema name #2365

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

clesaec
Copy link
Contributor

@clesaec clesaec commented Jul 18, 2023

What is the purpose of the change

AVRO-2254 :
Currently, SchemaResolver.unresolvedSchema method generate always schema with same name. The idea supply Zoltan Farkas is to generate another name each time.
So, the intent of this PR is just to transformed what is proposed in PR form.

Verifying this change

unio.avdl + union.avpr add test on this.

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@github-actions github-actions bot added the Java Pull Requests for Java binding label Jul 18, 2023
@martin-g martin-g changed the title AVRO-2254: [java] fix unresolved shema name AVRO-2254: [java] fix unresolved schema name Jul 18, 2023
Copy link
Contributor

@opwvhk opwvhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change in itself is good, but since AVRO-3403 is should also be applied to org.apache.avro.idl.SchemaResolver in the avro-idl module.

Can you please rebase the change on master, and then copy the change?

@clesaec clesaec force-pushed the avro-2254_unionWith2Record branch from 8a98795 to cd30eb9 Compare September 18, 2023 15:56
@clesaec clesaec requested a review from opwvhk September 18, 2023 16:00
@clesaec
Copy link
Contributor Author

clesaec commented Sep 19, 2023

The change in itself is good, but since AVRO-3403 is should also be applied to org.apache.avro.idl.SchemaResolver in the avro-idl module.

Can you please rebase the change on master, and then copy the change?

Done

@clesaec clesaec merged commit 1faa9f1 into apache:master Sep 19, 2023
13 checks passed
RanbirK pushed a commit to RanbirK/avro that referenced this pull request May 13, 2024
* AVRO-2254: fix unresolved shema name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java Pull Requests for Java binding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants