AVRO-3770: [csharp] Fix aliased fields being read twice #2269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mparry
changed the title
mparry
force-pushed
the
feature/reader-handle-aliases
branch
from
00985c7 to
0168c90
Compare
Baxom
approved these changes
Sep 27, 2023
|
Hello @mparry , do you plan to resolve conflicts and merge this branch ? |
Also, fix SpecificDefaultReader not handling aliases at all
mparry
force-pushed
the
feature/reader-handle-aliases
branch
from
0168c90 to
68cc8b7
Compare
|
@martin-g @zcsizmadia |
|
I have approved the CI checks! But someone with C# experience will have to review and approve it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This changes fixes some problems with the reading of aliases fields, as described in AVRO-3770.
Verifying this change
This change added tests and can be verified by running them - in particular,
Avro.Test.SpecificTests.Documentation