-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing links to APISIX consumer pages #2304
base: master
Are you sure you want to change the base?
Added missing links to APISIX consumer pages #2304
Conversation
There seems to be a dead link in the readme file. apisix-ingress-controller/README.md Lines 106 to 108 in fee11af
The new working link seems to be wrapping the old outdated link. This is causing the |
yes please |
@Revolyssup After looking into it further, I realized that the link is not working because https://git-contributor.com/?chart=contributorOverTime&repo=apache/apisix is down it seems? https://contributor-overtime-api.apiseven.com/repos? is giving an error. There is already an issue created in api7/contributor-graph for this: api7/contributor-graph#231. I can fix the readme link temporarily and add the image back once this is fixed. Does that sound good? |
5190e15 would fix the failing CI job. We can add the image back once api7/contributor-graph#231 is resolved. Please take a look! |
@Revolyssup Please take a look! |
Type of change:
What this PR does / why we need it:
Added the missing links mentioned in #2289.
Pre-submission checklist: