Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add stream[].match.host to ApisixRoute v2 spec #2257

Merged
merged 2 commits into from
Jul 5, 2024
Merged

docs: add stream[].match.host to ApisixRoute v2 spec #2257

merged 2 commits into from
Jul 5, 2024

Conversation

kayx23
Copy link
Member

@kayx23 kayx23 commented Jul 4, 2024

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Documentation
  • Refactor
  • Chore
  • CI/CD or Tests

What this PR does / why we need it:

Add stream[].match.host to ApisixRoute v2 spec.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

kayx23
kayx23 commented Jul 4, 2024
View reviewed changes
docs/en/latest/references/apisix_route_v2.md
@@ -78,6 +78,7 @@ The table below describes each of the attributes in the spec. The fields `apiVer
| stream[].name | string (required) | Name of the rule. |
| stream[].match | object (required) | Conditions to match the request with the Route. |
| stream[].match.ingressPort | integer (required) | Listening port in the Ingress proxy server. This port should be defined in the [APISIX configuration](https://github.com/apache/apisix/blob/master/conf/config-default.yaml#L101). |
| stream[].match.host | string | SNI. |
Copy link
Member Author

@kayx23 kayx23 Jul 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/apache/apisix-ingress-controller/blob/master/pkg/kube/apisix/apis/config/v2/types.go#L250

e2e test: https://github.com/apache/apisix-ingress-controller/blob/master/test/e2e/suite-ingress/suite-ingress-resource/stream.go#L106-L138

image

@kayx23 kayx23 closed this Jul 4, 2024
@kayx23 kayx23 deleted the docs-stream-route-host branch July 4, 2024 17:02
@kayx23 kayx23 restored the docs-stream-route-host branch July 4, 2024 17:02
@kayx23 kayx23 reopened this Jul 4, 2024
@kayx23 kayx23 merged commit bbcd8d9 into apache:master Jul 5, 2024
54 checks passed
@kayx23 kayx23 deleted the docs-stream-route-host branch July 5, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pottekkat pottekkat pottekkat approved these changes

@Revolyssup Revolyssup Revolyssup approved these changes

@juzhiyuan juzhiyuan Awaiting requested review from juzhiyuan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kayx23 @Revolyssup @pottekkat