Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

[REVIEW-ONLY] Fixed python implementation for Apache Apex #640

Closed

Conversation

patilvikram
Copy link
Contributor

This PR includes both stateless + stateful support based on High-Level APIs.

@patilvikram
Copy link
Contributor Author

@PramodSSImmaneni @tushargosavi
This PR includes all changes for python and we can reject earlier PR and move over to this one.

@tweise
Copy link
Contributor

tweise commented Jul 4, 2017

Why are you opening another PR? Keep on working on the existing PR to retain the communication trail.

@tweise
Copy link
Contributor

tweise commented Jul 4, 2017

Also see http://apex.apache.org/contributing.html#opening-pull-requests for how to open PRs.

@patilvikram
Copy link
Contributor Author

@tweise Actually older PR is not completely reviewed and I finished some initial work for supporting windowed operator in python using high-level apis. While doing that I have refactored lots of code and cleaned it, also included comments from already opened PR.

@patilvikram patilvikram force-pushed the python_binding_for_review_1 branch from 5a586aa to 79f68ee Compare July 6, 2017 16:24
@tweise
Copy link
Contributor

tweise commented Jul 6, 2017

@patilvikram PRs are updated with changes as they are reviewed, so that there is a single thread to follow the work. If you are not sure how that works after reading the guidelines, please consult other contributors in your office. Close #613 if you wan to continue here, but then please stick with it.

@patilvikram
Copy link
Contributor Author

I have merged all changes here to #613 so closing this now.

@patilvikram patilvikram closed this Jul 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants