[AMORO-3352]Add mysql-connector-j dependency by maven profile #3380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3380 +/- ##
============================================
+ Coverage 21.59% 21.62% +0.03%
- Complexity 2309 2313 +4
============================================
Files 426 426
Lines 39719 39724 +5
Branches 5624 5623 -1
============================================
+ Hits 8577 8591 +14
+ Misses 30414 30406 -8
+ Partials 728 727 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
XBaith
reviewed
Dec 27, 2024
| @@ -151,10 +151,12 @@ | |||
| <guava.version>32.1.1-jre</guava.version> | |||
| <hudi.version>0.14.1</hudi.version> | |||
| <pagehelper.version>6.1.0</pagehelper.version> | |||
| <mysql-connector-j.version>8.1.0</mysql-connector-j.version> | |||
There was a problem hiding this comment.
bump to latest version to fix CVE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #3352.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation