Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restart & stop shell script #3374

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ihadoop
Copy link
Contributor

@ihadoop ihadoop commented Dec 19, 2024

Why are the changes needed?

Close #3328.

Brief change log

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@klion26 klion26 self-requested a review December 20, 2024 02:21
@XBaith
Copy link
Contributor

XBaith commented Dec 20, 2024

Could you please align this PR with the Pull Request Guidelines?
This will ensure it meets the project's standards and is easier to review.

@klion26
Copy link
Member

klion26 commented Dec 23, 2024

@ihadoop, thanks for the contribution. As @XBaith commented, please respect the Pull Request Guidelines.

For the change, does it release the resources for the optimizers for the current change, or do we need to release the optimizers manually? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Support to stop/restart the optimizers when stop/restart the ams server
3 participants