Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] added tips for compiling for macos environment #3364

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheR1sing3un
Copy link
Member

  1. added tips for compiling for macos environment

Why are the changes needed?

Close #xxx.

Brief change log

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

1. added tips for compiling for macos environment
@github-actions github-actions bot added the type:docs Improvements or additions to documentation label Dec 10, 2024
@klion26
Copy link
Member

klion26 commented Dec 11, 2024

@TheR1sing3un Thanks for the contribution. Could you please share what the problem is if you are not using Oracle's JDK? Thanks.

@TheR1sing3un
Copy link
Member Author

@TheR1sing3un Thanks for the contribution. Could you please share what the problem is if you are not using Oracle's JDK? Thanks.

I have tried to compile with zulu-jdk8 and corretto-jdk8 but all failed like this:
image
The same problem exists in :#3321 .
After replacing open-jdk with oracle-jdk, everything is all right!

@huyuanfeng2018
Copy link
Contributor

@TheR1sing3un Thanks for the contribution. Could you please share what the problem is if you are not using Oracle's JDK? Thanks.

I have tried to compile with zulu-jdk8 and corretto-jdk8 but all failed like this: image The same problem exists in :#3321 . After replacing open-jdk with oracle-jdk, everything is all right!

I use zulu-jdk8 and no problems are found~ ~

@TheR1sing3un
Copy link
Member Author

@TheR1sing3un Thanks for the contribution. Could you please share what the problem is if you are not using Oracle's JDK? Thanks.

I have tried to compile with zulu-jdk8 and corretto-jdk8 but all failed like this: image The same problem exists in :#3321 . After replacing open-jdk with oracle-jdk, everything is all right!

I use zulu-jdk8 and no problems are found~ ~

Could u share your entire compile environment?

@huyuanfeng2018
Copy link
Contributor

@TheR1sing3un Thanks for the contribution. Could you please share what the problem is if you are not using Oracle's JDK? Thanks.

I have tried to compile with zulu-jdk8 and corretto-jdk8 but all failed like this: image The same problem exists in :#3321 . After replacing open-jdk with oracle-jdk, everything is all right!

I use zulu-jdk8 and no problems are found~ ~

Could u share your entire compile environment?

Apache Maven 3.8.6
openjdk version "1.8.0_332"
OpenJDK Runtime Environment (Zulu 8.62.0.19-CA-macos-aarch64) (build 1.8.0_332-b09)
OpenJDK 64-Bit Server VM (Zulu 8.62.0.19-CA-macos-aarch64) (build 25.332-b09, mixed mode)
You can refer to it.

@TheR1sing3un
Copy link
Member Author

@TheR1sing3un Thanks for the contribution. Could you please share what the problem is if you are not using Oracle's JDK? Thanks.

I have tried to compile with zulu-jdk8 and corretto-jdk8 but all failed like this: image The same problem exists in :#3321 . After replacing open-jdk with oracle-jdk, everything is all right!

I use zulu-jdk8 and no problems are found~ ~

Could u share your entire compile environment?

Apache Maven 3.8.6 openjdk version "1.8.0_332" OpenJDK Runtime Environment (Zulu 8.62.0.19-CA-macos-aarch64) (build 1.8.0_332-b09) OpenJDK 64-Bit Server VM (Zulu 8.62.0.19-CA-macos-aarch64) (build 25.332-b09, mixed mode) You can refer to it.

Thanks u! I will try again using your environment.

@zhoujinsong
Copy link
Contributor

zhoujinsong commented Dec 20, 2024

After we figure out the necessary requirements, we may add a maven-enforcer-plugin to help validate the environment. requireJavaVersion and requireJavaVendor seem to be suitable for this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants