-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] added tips for compiling for macos environment #3364
base: master
Are you sure you want to change the base?
Conversation
1. added tips for compiling for macos environment
@TheR1sing3un Thanks for the contribution. Could you please share what the problem is if you are not using Oracle's JDK? Thanks. |
I have tried to compile with zulu-jdk8 and corretto-jdk8 but all failed like this: |
I use zulu-jdk8 and no problems are found~ ~ |
Could u share your entire compile environment? |
Apache Maven 3.8.6 |
Thanks u! I will try again using your environment. |
After we figure out the necessary requirements, we may add a maven-enforcer-plugin to help validate the environment. requireJavaVersion and requireJavaVendor seem to be suitable for this case. |
Why are the changes needed?
Close #xxx.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation