-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow json_result_force_utf8_encoding
specification in providers.snowflake.hooks.SnowflakeHook
extra dict
#44264
Allow json_result_force_utf8_encoding
specification in providers.snowflake.hooks.SnowflakeHook
extra dict
#44264
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
…wflake-connector-argument
…wflake-connector-argument
…wflake-connector-argument
…wflake-connector-argument
…wflake-connector-argument
…wflake-connector-argument
…wflake-connector-argument
…wflake-connector-argument
…wflake-connector-argument
…wflake-connector-argument
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Motivation/Justification:
Snowflake's Python connector recommends using
json_result_force_utf8_decoding
toTrue
, but preserves it asFalse
/no-op for legacy reasons. I've come across cases at work where not setting this returns unexpected results, whereas setting it to True (via a workaround) returns the expected results.Therefore, I think there is a valid case for allowing this to be passed via connection arguments (via
extra
).Relevant 'upstream' Snowflake connector code
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.