Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove graphs from monitor #5108

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Remove graphs from monitor #5108

merged 2 commits into from
Nov 25, 2024

Conversation

DomGarguilo
Copy link
Member

Partially addresses #5091
This pull request includes several changes focused on removing the Flot library and related code from the project, as well as cleaning up unused imports and methods. The most important changes include the removal of Flot references from various license files, the deletion of Flot-related code from the Monitor.java class, and the removal of corresponding REST endpoints in StatisticsResource.java.

Removal of Flot library and related code:

  • LICENSE, assemble/src/main/resources/LICENSE, server/monitor/src/main/appended-resources/META-INF/LICENSE: Removed references to the Flot library and its dependencies.
  • server/monitor/src/main/resources/org/apache/accumulo/monitor/resources/external/flot/LICENSE.txt: Deleted the Flot license file.

Code cleanup in Monitor.java:

  • Removed unused imports and methods related to Flot, including newMaxList, fetchData, and various getter methods for metrics over time.

Removal of REST endpoints in StatisticsResource.java:

  • Deleted endpoints that provided metrics over time, such as scan rate, query rate, ingest rate, and cache hit rates.

CSS cleanup:

  • Removed CSS rules related to Flot from screen.css.

@DomGarguilo DomGarguilo self-assigned this Nov 25, 2024
@DomGarguilo DomGarguilo added this to the 3.1.0 milestone Nov 25, 2024
@DomGarguilo
Copy link
Member Author

All of the other pages look the same except the home page which no longer has the graphs:

image

@DomGarguilo DomGarguilo merged commit 0be5178 into apache:3.1 Nov 25, 2024
8 checks passed
@DomGarguilo DomGarguilo deleted the removeGraphs branch November 25, 2024 21:47
DomGarguilo added a commit that referenced this pull request Nov 27, 2024
PR #5108 removed the graphs from the monitor. A lot of supporting code was able to be removed too. This commit removes one of those methods that was left out of the initial PR.
@ctubbsii ctubbsii linked an issue Nov 27, 2024 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove graphs, problem reports and logs from the monitor
2 participants