Status & Reservation columns are now in their own column families #5031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinrr888
reviewed
Nov 6, 2024
server/base/src/main/java/org/apache/accumulo/server/init/InitialConfiguration.java
Outdated
Show resolved
Hide resolved
Comment on lines
+63
to
+77
| public static class StatusColumnFamily { | ||
| public static final String STR_NAME = "status"; | ||
| public static final Text NAME = new Text(STR_NAME); | ||
|
|
||
| public static final String STATUS = "status"; | ||
| public static final ColumnFQ STATUS_COLUMN = new ColumnFQ(NAME, new Text(STATUS)); | ||
| } | ||
|
|
||
| public static class ReservationColumnFamily { | ||
| public static final String STR_NAME = "reservation"; | ||
| public static final Text NAME = new Text(STR_NAME); | ||
|
|
||
| public static final String RESERVATION = "reservation"; | ||
| public static final ColumnFQ RESERVATION_COLUMN = new ColumnFQ(NAME, new Text(RESERVATION)); | ||
| } |
There was a problem hiding this comment.
Could put these two columns in a single column family, that avoids the duplication in family and qualifier. Some possible name for the family are txtAdmin, txMgmt, or txSituation. Tried admin in the suggestion below because was thinking this is information related to administering a fate transaction.
Suggested change
| public static class StatusColumnFamily { | |
| public static final String STR_NAME = "status"; | |
| public static final Text NAME = new Text(STR_NAME); | |
| public static final String STATUS = "status"; | |
| public static final ColumnFQ STATUS_COLUMN = new ColumnFQ(NAME, new Text(STATUS)); | |
| } | |
| public static class ReservationColumnFamily { | |
| public static final String STR_NAME = "reservation"; | |
| public static final Text NAME = new Text(STR_NAME); | |
| public static final String RESERVATION = "reservation"; | |
| public static final ColumnFQ RESERVATION_COLUMN = new ColumnFQ(NAME, new Text(RESERVATION)); | |
| } | |
| public static class TxAdminColumnFamily { | |
| public static final String STR_NAME = "txAdmin"; | |
| public static final Text NAME = new Text(STR_NAME); | |
| public static final String STATUS = "status"; | |
| public static final ColumnFQ STATUS_COLUMN = new ColumnFQ(NAME, new Text(STATUS)); | |
| public static final String RESERVATION = "reservation"; | |
| public static final ColumnFQ RESERVATION_COLUMN = new ColumnFQ(NAME, new Text(RESERVATION)); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Issue #4977
Moved StatusColumn & ReservationColumn in Fate into their own column Families, updated calls to the respective columns and added reservation locality group for initial config.