Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deplete compute meter for vm errors #3751

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jstarry
Copy link

@jstarry jstarry commented Nov 22, 2024

Problem

Implements SIMD-0182 by making sure that programs that fail with VM errors consume the remaining compute budget to simplify compute unit handling.

Summary of Changes

  • Consume remaining compute budget for all VM errors except those that originate from syscalls
  • Use existing replay cost tracker feature gate
  • Rekey replay cost tracker feature gate

Feature Gate Issue: solana-labs#29595

Copy link

mergify bot commented Nov 22, 2024

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@jstarry jstarry marked this pull request as ready for review November 22, 2024 19:31
@jstarry jstarry added the feature-gate Pull Request adds or modifies a runtime feature gate label Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-gate Pull Request adds or modifies a runtime feature gate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant