Extract message crate

[kevinheavey]

Problem

solana_program::message needs to be pulled out

Summary of Changes

• Move to its own crate and re-export with deprecation
• Move AddressLookupTableAccount to this crate
• Move CompiledInstruction to this crate
• Copy ALL_IDS from the sysvar module to avoid a dependency. This code is deprecated anyway so the stuff we are copying should not change.
• Inline the NONCED_TX_MARKER_IX_INDEX from solana_nonce to avoid a dependency
• Make serde and bincode optional in this crate
• Remove thiserror from the new crate
• Add doc_auto_cfg

This uses the solana-system-interface crate so that needs to be published before this can be merged (update: solana-system-interface has been published)

[joncinque]

Looks really good, just one suggestion to add a test and to revert some changes that might have snuck in. Is this the last of the painful crate extractions from solana-program?

[joncinque]

Were these changes intended?

[kevinheavey]

yes, for some reason the CI only complained about an unused import in this PR. Maybe the warning wasn't causing any CI to fail. But the warning is real

[joncinque]

Gotcha, makes sense -- it's unused in target_os = "solana", so if you run ./cargo-build-sbf --manifest-path sdk/transaction-error/Cargo.toml, you'll see that error warning. I'll put in a separate PR for that if that's ok

[joncinque]

#3742 fixes that and another thing

[joncinque]

Looks great, thanks! @yihau can you accept solana-message?

[mergify]

automerge label removed due to a CI failure

[mergify]

automerge label removed due to a CI failure

[joncinque]

Sorry, can you rebase once more to pick up #3774 ?

[mergify]

automerge label removed due to a CI failure

[kevinheavey]

Need to figure out some doctest dependency issues

[joncinque]

Need to figure out some doctest dependency issues

There's another issue with the cargo build-sbf tests -- since they're using a local solana-program without patching the deps for solana-system-interface, the build pulls in two versions of solana-pubkey / solana-instruction / solana-decode-error. I can push up a fix for this if you like

[kevinheavey]

Oh yes please, maybe that's it

[joncinque]

I think we're looking good! Tagged @febo for an approval since I can't merge it 🙃

[febo]

Looks great! There are some CI tasks failing.

[joncinque]

Looks like there's a missing dependency on wasm-bindgen. But even after fixing that, there's multiply defined symbols for the system instructions between solana-system-interface and sdk/program/src/system_instruction.rs -- we'll need to remove those first and change solana-program to re-export all of those.

[febo]

Looks like there's a missing dependency on wasm-bindgen. But even after fixing that, there's multiply defined symbols for the system instructions between solana-system-interface and sdk/program/src/system_instruction.rs -- we'll need to remove those first and change solana-program to re-export all of those.

Would you like me do have a look at it?

[joncinque]

Would you like me do have a look at it?

Yes please that'd be great, whenever you have a moment