Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract solana-transaction from solana-sdk #3634

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

kevinheavey
Copy link

@kevinheavey kevinheavey commented Nov 14, 2024

Problem

solana_sdk::transaction needs to be pulled out of solana_sdk

Summary of Changes

  • Move to its own crate and re-export for backwards compatibility as required, with deprecation notices
  • Move solana_sdk::simple_vote_transaction_checker to this crate (not much choice here as there'd be a circular dep otherwise)
  • Move solana_sdk::transaction::Result to solana_transaction_error::TransactionResult and re-export in solana_sdk::transaction with deprecation. This should have been done before but it was quite noticeable when moving things that it clearly belongs in solana_transaction_error
  • Put the verify_precompiles methods behind a feature gate "precompiles", as these bring in extra dependencies
  • Put the other verify and verify_* methods behind a feature gate "verify", as they bring in extra dependencies (not as many as the precompiles though)
  • Make serde and bincode optional in the new crate. The new crate still depends indirectly on serde and bincode for now because it depends on solana-program

This branches off #3622 so that needs to be merged first (update: done)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant