forked from solana-labs/solana
-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract solana-transaction from solana-sdk #3634
Open
kevinheavey
wants to merge
13
commits into
anza-xyz:master
Choose a base branch
from
kevinheavey:extract-transaction
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+461
−242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinheavey
force-pushed
the
extract-transaction
branch
5 times, most recently
from
November 14, 2024 17:00
3186d52
to
303be04
Compare
kevinheavey
force-pushed
the
extract-transaction
branch
5 times, most recently
from
November 21, 2024 00:15
0dcdc95
to
936e4af
Compare
kevinheavey
force-pushed
the
extract-transaction
branch
from
November 25, 2024 17:27
936e4af
to
b778d4e
Compare
kevinheavey
force-pushed
the
extract-transaction
branch
from
November 25, 2024 22:13
dd083ed
to
86eeea0
Compare
kevinheavey
force-pushed
the
extract-transaction
branch
from
November 26, 2024 07:28
86eeea0
to
dcd740a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
solana_sdk::transaction
needs to be pulled out ofsolana_sdk
Summary of Changes
solana_sdk::simple_vote_transaction_checker
to this crate (not much choice here as there'd be a circular dep otherwise)solana_sdk::transaction::Result
tosolana_transaction_error::TransactionResult
and re-export insolana_sdk::transaction
with deprecation. This should have been done before but it was quite noticeable when moving things that it clearly belongs insolana_transaction_error
verify_precompiles
methods behind a feature gate "precompiles", as these bring in extra dependenciesverify
andverify_*
methods behind a feature gate "verify", as they bring in extra dependencies (not as many as the precompiles though)This branches off #3622 so that needs to be merged first (update: done)