MailPace: New ESP #354
Closed
MailPace: New ESP #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
More issues than expected on the other Python versions - we'll fix them locally and re-open a PR once complete (with signed commits) |
|
Thanks, looking forward to it! One problem causing multiple failing tests is the optional library: anymail.webhooks.mailpace needs to be importable whether or not pynacl is installed. There's a decent example of how to handle that in anymail.webhooks.resend. |
|
Thanks! I've attempted that pattern in the new PR 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Anymail team, thanks for building such well designed and easy to extend software! We're an ESP (https://mailpace.com) that would like to be fully out of the box with you.
Let us know if there's more we need to do, or improvements to the code that we can make.