New signed streams #202
Merged
New signed streams #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palkan
force-pushed
the
feat/signed-streams-v2
branch
from
043a766
to
dfdc26a
Compare
- Add $pubsub channel for direct pub/sub support - Unify signed stream controllers implementations
palkan
force-pushed
the
feat/signed-streams-v2
branch
from
dfdc26a
to
c139e99
Compare
- Rename jwt options (drop _id)
palkan
force-pushed
the
feat/signed-streams-v2
branch
2 times, most recently
from
9591ada
to
8c14a1c
Compare
palkan
force-pushed
the
feat/signed-streams-v2
branch
from
8c14a1c
to
4f16b99
Compare
palkan
force-pushed
the
feat/signed-streams-v2
branch
from
ec17f3e
to
330f481
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Revisit signed streams implementation and introduce a standalone mode—an upgraded version of RPC-less setup suitable for any application (not only Hotwire).
What changes did you make? (overview)
Added a reserved "$pubsub" channel for direct pub/sub support
Unifed signed stream controllers implementations
--streams_secret$pubsubwith--public_streamsmust be used instead)Renamed JWT params and simplified terminology (switch focus from identification to authentication for the standalone mode)
Add no auth mode (
--noauth)Introduce shortcut configuration options (
--secret,--public)Introduce
--broadcast_keyoption (instead of older--http_broadcast_secret, but can be used with other broadcasters)Auto-generate broadcast key and RPC secret from the application secret (if not set explicitly)
Added new broadcasting docs (AnyCable server oriented)
Added new RPC docs
HTTP broadcaster is enabled by default
Changes in other libraries
anycable:AnyCable.signed_stream(val)andconfig.streams_secretandconfig.secretanycable: upgrade HTTP adapter and RPC HTTP to auto-generate auth secrets from the application secretanycable: added JWTanycable-rails:#signed_stream_namehelperanycable-rails: JWT integration@anycable/core:cable.streamFrom(...)andcable.streamFromSigned(...).@anycable/serverless:signStream(name: string): string@anycable/serverless: upgrade broadcaster to sign requestsIs there anything you'd like reviewers to focus on?
Check out the docs:
Checklist