Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@antonioru I began this from the new Constants.js file you created for feature/canvas.
This now exposes the event point as an object instead of the usual array. I do like this as it's more explicit. However I started running into places where the array was still expected. I took the liberty of updating those areas to create/refer to an {x, y} object instead. Let me know if this makes sense or you'd rather revert to the [x, y] option.
*On another note I did notice that dragging the new canvas, creates a scroll. I had tackled something similar in the original PR #67 with
touch-action: none;
inside diagram.scss. But since you're still working on the canvas feature, didn't want to try and address.Description
Add touch support for:
Related Issue
Closes #60 and replaces PR #67
Motivation and Context
Closes #60
How Has This Been Tested?
All existing tests are passing.
Tested on the Chrome mobile simulator on a mac and Safari on an iPad.