Update makePath to fix curve for verticallly aligned ports #102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the way the curve is drawn.
Description
Modified the MD files so the changes can be quickly tested. I'll remove those changes from the markdown if approved.
Inside the method, I propose a change of naming convention, this is not necessary and happy to keep it as is (original naming convention is commented above to test).
Also targeted the inversion of the controlOffset in case the source and target shift places vertically. Without it we get this behavior:
Target is below and we get a nice curve
Target is now above and the curve breaks due to the control points not being updated:
If the fix for this looks good, we can replicate for the horizontally aligned ports, since we get the same behavior there.
Motivation and Context
Show a more clear path from source to target
How Has This Been Tested?
Manually on Chrome and existing tests are passing