Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update makePath to fix curve for verticallly aligned ports #102

Open
wants to merge 1 commit into
base: feature/canvas-ext
Choose a base branch
from

Conversation

joancc
Copy link

@joancc joancc commented Dec 19, 2020

Update the way the curve is drawn.

Description

Modified the MD files so the changes can be quickly tested. I'll remove those changes from the markdown if approved.
Inside the method, I propose a change of naming convention, this is not necessary and happy to keep it as is (original naming convention is commented above to test).
Also targeted the inversion of the controlOffset in case the source and target shift places vertically. Without it we get this behavior:

Target is below and we get a nice curve
Screen Shot 2020-12-19 at 11 45 09 AM

Target is now above and the curve breaks due to the control points not being updated:
Screen Shot 2020-12-19 at 11 45 21 AM

If the fix for this looks good, we can replicate for the horizontally aligned ports, since we get the same behavior there.

Motivation and Context

Show a more clear path from source to target

How Has This Been Tested?

Manually on Chrome and existing tests are passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant