Release v0.6.4

.travis.yml

@@ -1,22 +1,23 @@
 ---
-sudo: false
 language: ruby
 rvm:
-  - 1.8.7
-  - 1.9.3
   - 2.0.0
   - 2.1.10
   - 2.2.5
   - 2.3.1
 env:
-  - PUPPET_GEM_VERSION="~> 3.7"
-  - PUPPET_GEM_VERSION="~> 4.0"
+  - PUPPET_GEM_VERSION="~> 3.7.0"
+  - PUPPET_GEM_VERSION="~> 3.8.0"
+  - PUPPET_GEM_VERSION="~> 4.4.0"
+  - PUPPET_GEM_VERSION="~> 4.6.0"
 matrix:
   exclude:
-    - rvm: 1.8.7
-      env: PUPPET_GEM_VERSION="~> 4.0"
     - rvm: 2.2.5
-      env: PUPPET_GEM_VERSION="~> 3.7"
+      env: PUPPET_GEM_VERSION="~> 3.7.0"
     - rvm: 2.3.1
-      env: PUPPET_GEM_VERSION="~> 3.7"
+      env: PUPPET_GEM_VERSION="~> 3.7.0"
+    - rvm: 2.2.5
+      env: PUPPET_GEM_VERSION="~> 3.8.0"
+    - rvm: 2.3.1
+      env: PUPPET_GEM_VERSION="~> 3.8.0"
   fast_finish: true

CHANGELOG.md

@@ -1,58 +1,62 @@
-###0.6.3
+### 0.6.4
 
- New parameter `skip_broken` ([mpuel](https://github.com/mpuel))
+New parameter `systemname` ([jcpunk](https://github.com/jcpunk))
 
-###0.6.2
+### 0.6.3
+
+New parameter `skip_broken` ([mpuel](https://github.com/mpuel))
+
+### 0.6.2
 
 * Fix compatibility with Puppet 2.7 ([jenkins101](https://github.com/jenkins101))
 * Partial revert of changes introduced in v0.6.1 (Puppet 4.x)
 
-###0.6.1
+### 0.6.1
 
 * Fix compatibility with Puppet 4.0 ([jhoblitt](https://github.com/jhoblitt))
 * Housekeeping for Travis CI ([jhoblitt](https://github.com/jhoblitt))
 * Support Fedora 22
 
-###0.6.0
+### 0.6.0
 
 * Added spec tests, see documentation for guidelines
 * Minor bugfixes
 
-###0.5.1
+### 0.5.1
 
 Fix compatibility with future parser in Puppet 3.7.4 ([PUP-3615](https://tickets.puppetlabs.com/browse/PUP-3615))
 
-###0.5.0
+### 0.5.0
 
 * Add custom schedules via the `yum_autoupdate::schedule` defined type
 * Drop support for Fedora 17 and 18
 * Compatible with future parser
 
-###0.4.1
+### 0.4.1
 
 * Improve code quality, doc and metadata
 * Support Fedora 21
 
-###0.4.0
+### 0.4.0
 
 * `update_cmd` can now be defined ([ksaio](https://github.com/ksaio)!)
 * Deletion of the default hourly schedule on RHEL 7/Fedora 19+
 * Make Puppet Doc compliant with RDoc markup language
 * Refactoring
 
-###0.3.2
+### 0.3.2
 
 * Remove `email_from` feature from CentOS 5, since it is not supported
 * Updated documentation
 
-###0.3.1
+### 0.3.1
 
 * Adjust default `debug_level` depending on the platform
 * `debug_level` is enforced to `-1` when `notify_email` is set to `false`
 * Updated documentation
 * Removed unused `download_only` parameter (leftover)
 
-###0.3.0
+### 0.3.0
 
 * Class parameter changes. See documentation for usage
   * New class parameter `notify_email` (boolean) to disable email notifications in a more consistent way
@@ -61,16 +65,16 @@ Fix compatibility with future parser in Puppet 3.7.4 ([PUP-3615](https://tickets
     * NOTE: use the `--force` option to upgrade to this release
 * Updated documentation
 
-###0.2.0
+### 0.2.0
 
 * Added support for Fedora 15+
 
-###0.1.1
+### 0.1.1
 
 * Move package exclusion logic from ERB templates to Puppet STL
 * Added To Do documentation section
 * Added this changelog
 
-###0.1.0
+### 0.1.0
 
 First forge release

Gemfile

@@ -8,16 +8,3 @@ end
 
 gem 'puppetlabs_spec_helper', :require => false
 gem 'metadata-json-lint',     :require => false
-
-## compatibility
-
-platforms :ruby_18 do
-  # https://github.com/rspec/rspec-core/issues/1864
-  gem 'rspec', '< 3.2.0',  :require => false
-  gem 'rake',  '< 11.0.0', :require => false
-end
-
-platforms :ruby_18, :ruby_19 do
-  gem 'json',      '< 2.0.0', :require => false
-  gem 'json_pure', '< 2.0.0', :require => false
-end

README.md

@@ -1,7 +1,7 @@
-#yum_autoupdate
+# yum_autoupdate
 [![Build Status](https://travis-ci.org/antoineco/aco-yum_autoupdate.svg?branch=master)](https://travis-ci.org/antoineco/aco-yum_autoupdate)
 
-####Table of Contents
+#### Table of Contents
 
 1. [Overview - What is the yum_autoupdate module?](#overview)
 2. [Module Description - What does the module do?](#module-description)
@@ -16,15 +16,15 @@
 6. [Testing - How to run the included spec tests](#testing)
 7. [Contributors](#contributors)
 
-##Overview
+## Overview
 
 The yum_autoupdate module allows you to configure automatic updates on all [RHEL variants](http://en.wikipedia.org/wiki/List_of_Linux_distributions#RHEL-based) including Fedora.
 
-##Module description
+## Module description
 
 The yum-cron service enables scheduled system updates on RHEL-based systems. This module allows you to install and configure this service without the need to fiddle manually with configuration files, which may vary from one major version to the other on most RHEL-based distributions.
 
-##Setup
+## Setup
 
 yum_autoupdate will affect the following parts of your system:
 
@@ -38,7 +38,7 @@ Including the main class is enough to get started. It will enable automatic upda
 include ::yum_autoupdate
 ```
 
-####A couple of examples
+#### A couple of examples
 
 Disable emails and just download updates, do not apply
 
@@ -116,76 +116,76 @@ yum_autoupdate::schedule { 'daily download':
 }
 ```
 
-##Usage
+## Usage
 
-####Class: `yum_autoupdate`
+#### Class: `yum_autoupdate`
 
 Primary class and entry point of the module.
 
 **Parameters within `yum_autoupdate`:**
 
-#####`service_ensure`
+##### `service_ensure`
 Whether the service should be running. Valid values are `stopped` and `running`. Defaults to `running`
 
-#####`service_enable`
+##### `service_enable`
 Whether to enable the yum-cron service. Boolean value. Defaults to `true`
 
-#####`default_schedule`
+##### `default_schedule`
 Wheteher to enable the default daily schedule. If yes, configure it using the class parameters. Boolean value. Defaults to `true`
 
-#####`keep_default_hourly`
+##### `keep_default_hourly`
 Wheteher to keep the default hourly check. Boolean value. Defaults to `false`
 
 See also [Common parameters](#common-parameters)
 
-####Define: `yum_autoupdate::schedule`
+#### Define: `yum_autoupdate::schedule`
 
 Create a yum-cron schedule
 
 **Parameters within `yum_autoupdate::schedule`:**
 
-#####`user`, `hour`, `minute`, `month`, `monthday`, `weekday`, `special`
+##### `user`, `hour`, `minute`, `month`, `monthday`, `weekday`, `special`
 Please read [Puppet cron type](https://docs.puppetlabs.com/references/latest/type.html#cron)
 
 See also [Common parameters](#common-parameters)
 
-####Common parameters
+#### Common parameters
 
 Parameters common to both `yum_autoupdate` and `yum_autoupdate::schedule`
 
-#####`action`
+##### `action`
 Mode in which yum-cron should perform. Valid values are `check`, `download` and `apply`. Defaults to `apply`
 
-#####`exclude`
+##### `exclude`
 Array of packages to exclude from automatic update. Defaults to `[]`
 
-#####`notify_email`
+##### `notify_email`
 Enable email notifications. Boolean value. Defaults to `true`  
 It is recommended to also adjust debug/error levels accordingly (see below) 
 
-#####`email_to`
+##### `email_to`
 Recipient email address for update notifications. Defaults to `root` (local user)  
 An empty string forces the output to stdio, so emails will be sent by crond
 
-#####`email_from`
+##### `email_from`
 Sender email address for update notifications. No effect when `email_to` is empty. Defaults to `root` (local user)  
 *Note:* not supported on CentOS 5
 
-#####`debug_level`
+##### `debug_level`
 YUM debug level. Valid values are numbers between `-1` and `10`. `-1` to disable. Default depends on the platform  
 Enforced to `-1` when `notify_email` is `false`  
 *Notes:*
 * `-1` is necessary to also suppress messages from deltarpm, since `0` doesn't
 * Always outputs to stdio on modern platforms, can apparently not be changed
 
-#####`error_level`
+##### `error_level`
 YUM error level. Valid values are numbers between `0` and `10`. `0` to disable. Defaults to `0`  
 *Note:* always outputs to stdio on modern platforms, can apparently not be changed
 
-#####`skip_broken`
+##### `skip_broken`
 Enable YUM `--skip-broken` option. Boolean value. Defaults to `false`
 
-#####`update_cmd`
+##### `update_cmd`
 What updates to install, based on RedHat erratas. Valid values are:
 * `default` (all available updates)
 * `security` (only packages with a security errata)
@@ -198,19 +198,19 @@ Defaults to `default`
 
 *Note:* only supported on RHEL 7 and Fedora
 
-#####`randomwait`
+##### `randomwait`
 
 Maximum amount of time in minutes YUM randomly waits before running. Valid values are numbers between `0` and `1440`. `0` to disable. Defaults to `60`
 
-#####`systemname`
+##### `systemname`
 
 Hostname to use for identification. Defaults to `undef` which should be automatically converted to the system hostname.
 
-##To Do
+## To Do
 
 * Add support for passing arbitrary parameters to YUM
 
-##Testing
+## Testing
 
 The only prerequisite is to have the [Bundler](http://bundler.io/) gem installed:
 
@@ -232,8 +232,9 @@ $ bundle exec rake spec
 
 Check the [puppetlabs_spec_helper](https://github.com/puppetlabs/puppetlabs_spec_helper) GitHub repository for more information.
 
-##Contributors
+## Contributors
 
+* [Pat Riehecky](https://github.com/jcpunk)
 * [Kim Stig Andersen](https://github.com/ksaio)
 * [Joshua Hoblitt](https://github.com/jhoblitt)
 * [Daniel Forsberg](https://github.com/jenkins101)

manifests/init.pp

@@ -94,10 +94,12 @@
   }
 
   # package installation and service configuration
-  package { 'yum-cron': ensure => present } ->
+  package { 'yum-cron': ensure => present }
+
   service { 'yum-cron':
-    ensure => $service_ensure,
-    enable => $service_enable
+    ensure  => $service_ensure,
+    enable  => $service_enable,
+    require => Package['yum-cron']
   }
 
   # don't attempt any file replacement before the package is installed

manifests/schedule.pp

@@ -126,7 +126,8 @@
     path    => "/etc/yum/schedules/yum-cron_${name_real}",
     content => template("${module_name}/schedule/${yum_autoupdate::params::schedule_tpl}"),
     mode    => '0755'
-  } ->
+  }
+
   cron { "yum-cron ${name} schedule":
     ensure   => present,
     command  => "/etc/yum/schedules/yum-cron_${name_real}",
@@ -136,6 +137,7 @@
     month    => $month,
     monthday => $monthday,
     weekday  => $weekday,
-    special  => $special
+    special  => $special,
+    require  => File["yum-cron ${name} schedule"]
   }
 }

metadata.json

@@ -5,7 +5,7 @@
   "project_page": "https://github.com/antoineco/aco-yum_autoupdate",
   "source": "git://github.com/antoineco/aco-yum_autoupdate.git",
   "summary": "Puppet module for scheduled system updates on RHEL variants",
-  "version": "0.6.3",
+  "version": "0.6.4",
   "tags": ["unattended","update","yum"],
   "dependencies": [
     {
@@ -53,15 +53,12 @@
         "21",
         "22",
         "23",
-        "24"
+        "24",
+        "25"
       ]
     }
   ],
   "requirements": [
-    {
-      "name": "pe",
-      "version_requirement": ">= 3.0.0"
-    },
     {
       "name": "puppet",
       "version_requirement": ">= 2.7.0"