Building in debug and coverage when issuing the proper env variables #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there @antirez , this PR enables building rax in debug and coverage modes by passing DEBUG=1 COV=1 environment variables.
The reason I opened this PR was that the DEBUG variable within the makefile is to generic and can lead to potential build issues on repos that use rax as a dependency. The following build command on a project ( named myproject ) that relies on rax would not generate a successfull rax build if the parent project uses DEBUG=1 as a normal way to build debug binaries.
project1: make DEBUG=1 myprojectthis would also trigger the build o rax that would fail due to DEBUG flags being now overriden by 1.
Given that this is a common pratice (use DEBUG=1 env variable ) would you swith to this? wdyt?