Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create standalone evictor pages, date last updated, and backlinks to AEMP site #11

Open
wants to merge 5 commits into
base: staging
Choose a base branch
from

Conversation

dpsgit
Copy link

@dpsgit dpsgit commented Mar 26, 2024

Adds a few changes:

  • Adds a new page for single evictors, under the URL https://worstevictorsbayarea.org/evictor/{evictor_name} such as https://worstevictorsbayarea.org/evictor/robert-imhoff. Uses the "formatted" version of the evictor name, which is lowercased and dash-separated. These standalone pages are not linked anywhere on the site.
  • Adds a field on the evictor profiles for the date the profile was last updated (corresponding to a new lastUpdated field in the evictor Contentful model)
  • Adds a button on the evictor profile for the backlink to the historical AEMP page (corresponding to a new aempUrl field in the evictor Contentful model)
  • Also made some automatic formatting changes, but can revert those as needed

So far, I've only populated these new fields for Robert Imhoff. I also put these fields pretty arbitrarily in the left sidebar, which is now getting pretty busy, and probably should be moved elsewhere.

@dpsgit dpsgit requested a review from 18kimn March 26, 2024 18:24
Copy link
Contributor

@18kimn 18kimn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- see my comment about the SEO/socials preview thing! Also, looks like it fails to build, not sure if that will be a thing fixed by filling out Contentful profiles on first glance:

03-26-24_14:41:03


return (
<Layout
customTitle="The Worst Evictors of San Francisco and Oakland"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we adjust customTitle to be "${evictorName} | The Worst Evictors of... ", so that the SEO previews are evictor-specific?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants