Add divider line in between city / county / state/province / nation chunks of data in pop up info window box issue 41 fix #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isthewhiz
requested review from
benjaminben and
c5inco
and removed request for
benjaminben
c5inco
requested changes
May 23, 2021
| @@ -44,6 +45,7 @@ | |||
| font-size: 1.4rem; | |||
| overflow-wrap: break-word; | |||
| overflow-x: hidden; | |||
| border-bottom: 1px solid black; | |||
There was a problem hiding this comment.
I think the line should extend edge-to-edge in the InfoWindow. Right now there's padding that makes it look a bit awkward. That being said, related to my overall comment on this PR, let's circle back with Brett on the design in context of the collapsible sections design changes.
c5inco
requested changes
May 23, 2021
There was a problem hiding this comment.
Hmm the change looks simple but I wonder if this is the design that @brett-halperin intended? Looking at the linked issue, there is no mockup, so I think what we should do is revisit the design of the divider in context with the latest designs on having collapsible sections.
|
Sounds good!
…Sent from my iPhone
On May 23, 2021, at 11:31 AM, Chris Sinco ***@***.***> wrote:
@c5inco requested changes on this pull request.
Hmm the change looks simple but I wonder if this is the design that @brett-halperin intended? Looking at the linked issue, there is no mockup, so I think what we should do is revisit the design of the divider in context with the latest designs on having collapsible sections.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.