Skip to content
This repository has been archived by the owner on May 19, 2020. It is now read-only.

Add HMI test for tci #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Ydrasil
Copy link
Contributor

@Ydrasil Ydrasil commented Jun 21, 2017

Maybe we have to find a better way to check the end of a survey (we already check this in unit tests I don't know if we have to reproduce the test here)
For the URL I think we have to automatize it with a script like #20
cc @vinyll

Copy link
Member

@vinyll vinyll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Globally good for me :)

Just suggesting to move to ES6: replace var by const everywhere. It if fails, use let ;)

And removing semicolumns would be a plus (less is better)

test/hmi/tci.js Outdated
@@ -0,0 +1,31 @@
var Nightmare = require('nightmare');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const Nightmare =

test/hmi/tci.js Outdated
@@ -0,0 +1,31 @@
var Nightmare = require('nightmare');
var vo = require('vo');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const vo =…

test/hmi/tci.js Outdated
var Nightmare = require('nightmare');
var vo = require('vo');

vo(run)(function(err, result) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vo(run)((err, result) => { …

test/hmi/tci.js Outdated
});

function* run() {
var nightmare = Nightmare({ show:true })
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const nightmare …

test/hmi/tci.js Outdated
var testIsRunning = false

yield nightmare
.goto('http://127.0.0.1:5000/e8a92eadb3b86c0124193ee86ffdebbb')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do you get this token from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got this token from the script in #20

package.json Outdated
"license": "MIT"
"license": "MIT",
"devDependencies": {
"electron": "^1.6.11",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why Electron?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I had added electron for testing something with nightmare, I've removed it

package.json Outdated
"devDependencies": {
"electron": "^1.6.11",
"nightmare": "^2.10.0",
"vo": "^4.0.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is vo?

Copy link
Contributor Author

@Ydrasil Ydrasil Jun 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants