Skip to content
This repository has been archived by the owner on May 19, 2020. It is now read-only.

Add presentation page before surveys #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ydrasil
Copy link
Contributor

@Ydrasil Ydrasil commented May 30, 2017

I prefer to put the translation in an other PR instead of putting translation and presentation page in the same PR
For the text in the presentation, I'm waiting for the correct one.

Copy link
Member

@vinyll vinyll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still need to visually test it before approval

static/style.css Outdated
@@ -120,3 +120,6 @@ button {
.incomplete button {
display: none;
}
#beginButton {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use dash instead of camelCase.

@@ -36,6 +52,11 @@
let answers = []
let times = []

function showSurvey() {
document.querySelector('#begin').style.display = "none"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use single quotes

@@ -36,6 +52,11 @@
let answers = []
let times = []

function showSurvey() {
document.querySelector('#begin').style.display = "none"
document.querySelector('#survey').removeAttribute("hidden")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

single quotes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants