This repository has been archived by the owner on May 19, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Add presentation page before surveys #16
Open
Ydrasil
wants to merge
1
commit into
anthropedia:master
Choose a base branch
from
Ydrasil:presentation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinyll
suggested changes
Jun 15, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still need to visually test it before approval
static/style.css
Outdated
@@ -120,3 +120,6 @@ button { | |||
.incomplete button { | |||
display: none; | |||
} | |||
#beginButton { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use dash instead of camelCase.
templates/survey.html
Outdated
@@ -36,6 +52,11 @@ | |||
let answers = [] | |||
let times = [] | |||
|
|||
function showSurvey() { | |||
document.querySelector('#begin').style.display = "none" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use single quotes
templates/survey.html
Outdated
@@ -36,6 +52,11 @@ | |||
let answers = [] | |||
let times = [] | |||
|
|||
function showSurvey() { | |||
document.querySelector('#begin').style.display = "none" | |||
document.querySelector('#survey').removeAttribute("hidden") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
single quotes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I prefer to put the translation in an other PR instead of putting translation and presentation page in the same PR
For the text in the presentation, I'm waiting for the correct one.