Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update ansys-dpf-core #3082

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

build: update ansys-dpf-core #3082

wants to merge 13 commits into from

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented May 10, 2024

As the title.

@germa89 germa89 requested a review from a team as a code owner May 10, 2024 09:28
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89
Copy link
Collaborator Author

germa89 commented May 10, 2024

Just testing.

@germa89
Copy link
Collaborator Author

germa89 commented May 10, 2024

Hopefully this has been addressed in the new version: ansys/pydpf-core#1438

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.99%. Comparing base (3635824) to head (05950e6).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3082      +/-   ##
==========================================
+ Coverage   86.94%   86.99%   +0.05%     
==========================================
  Files         187      187              
  Lines       14622    14623       +1     
==========================================
+ Hits        12713    12722       +9     
+ Misses       1909     1901       -8     

@germa89
Copy link
Collaborator Author

germa89 commented May 10, 2024

Still broken. @PProfizi

@germa89 germa89 marked this pull request as draft May 10, 2024 09:47
@germa89 germa89 added the DO NOT MERGE Not ready to be merged yet label May 10, 2024
@PProfizi
Copy link
Contributor

Hi @germa89,

Looking at the error, it seems you get the error linked to the change in operator naming for NMISC and SMISC.
I think you are already aware that sadly there was a breaking change on those. I just would like to understand why you would get this error here. What server version is this pipeline using?
I see a Docker image for 22.2 being used, isn't that a bit old?

@germa89
Copy link
Collaborator Author

germa89 commented May 13, 2024

Hi @germa89,

Looking at the error, it seems you get the error linked to the change in operator naming for NMISC and SMISC. I think you are already aware that sadly there was a breaking change on those. I just would like to understand why you would get this error here. What server version is this pipeline using? I see a Docker image for 22.2 being used, isn't that a bit old?

Hi @PProfizi

Yes, it is a bit old. But I didn't have the time to figure it out how to deploy a newer version of DPF in our CICD. I know the docker registry I'm using hasn't been updated in 2 years. I'm happy to get some guidance on how to use newer versions of DPF in our CICD.

@PProfizi
Copy link
Contributor

Hi @germa89,
Looking at the error, it seems you get the error linked to the change in operator naming for NMISC and SMISC. I think you are already aware that sadly there was a breaking change on those. I just would like to understand why you would get this error here. What server version is this pipeline using? I see a Docker image for 22.2 being used, isn't that a bit old?

Hi @PProfizi

Yes, it is a bit old. But I didn't have the time to figure it out how to deploy a newer version of DPF in our CICD. I know the docker registry I'm using hasn't been updated in 2 years. I'm happy to get some guidance on how to use newer versions of DPF in our CICD.

Hi @germa89, do you necessarily need to go through the Docker registry?
We do have a GitHub action to install DPF, which you can see used here.

@germa89
Copy link
Collaborator Author

germa89 commented Jun 24, 2024

Hi @germa89,
Looking at the error, it seems you get the error linked to the change in operator naming for NMISC and SMISC. I think you are already aware that sadly there was a breaking change on those. I just would like to understand why you would get this error here. What server version is this pipeline using? I see a Docker image for 22.2 being used, isn't that a bit old?

Hi @PProfizi
Yes, it is a bit old. But I didn't have the time to figure it out how to deploy a newer version of DPF in our CICD. I know the docker registry I'm using hasn't been updated in 2 years. I'm happy to get some guidance on how to use newer versions of DPF in our CICD.

Hi @germa89, do you necessarily need to go through the Docker registry? We do have a GitHub action to install DPF, which you can see used here.

I do not need to go through the docker route. However, any proposed solution should work on github runners outside Ansys network. Do the action works in that way?

@PProfizi
Copy link
Contributor

Hi @germa89,
Looking at the error, it seems you get the error linked to the change in operator naming for NMISC and SMISC. I think you are already aware that sadly there was a breaking change on those. I just would like to understand why you would get this error here. What server version is this pipeline using? I see a Docker image for 22.2 being used, isn't that a bit old?

Hi @PProfizi
Yes, it is a bit old. But I didn't have the time to figure it out how to deploy a newer version of DPF in our CICD. I know the docker registry I'm using hasn't been updated in 2 years. I'm happy to get some guidance on how to use newer versions of DPF in our CICD.

Hi @germa89, do you necessarily need to go through the Docker registry? We do have a GitHub action to install DPF, which you can see used here.

I do not need to go through the docker route. However, any proposed solution should work on github runners outside Ansys network. Do the action works in that way?

Yes, we use it on GitHub runners outside of the Ansys network. It just needs access via a secret to a token to our DPF server repo.

@germa89
Copy link
Collaborator Author

germa89 commented Jun 25, 2024

@PProfizi thank you a lot for this! I will start to work on this after next week.

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc dependencies maintenance General maintenance of the repo (libraries, cicd, etc) labels Jul 8, 2024
@germa89 germa89 marked this pull request as ready for review November 26, 2024 10:44
@germa89 germa89 changed the title Update ansys-dpf-core build: update ansys-dpf-core Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc dependencies DO NOT MERGE Not ready to be merged yet maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants