Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Set DOTNET_ROOT with str and not Path #933

Merged
merged 3 commits into from
Dec 7, 2024

Conversation

SMoraisAnsys
Copy link
Collaborator

As pointed out in https://github.com/ansys/pyedb/pull/924/files#r1870405256, the value that we are passing to os.environ is a Path instance while it should be str. This solves this issue.

@isaacwaldron I'll check that this works correctly when I get back from my trip and make a new release.

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.67%. Comparing base (59d21f1) to head (3a3445b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #933   +/-   ##
=======================================
  Coverage   82.66%   82.67%           
=======================================
  Files         160      160           
  Lines       21037    21037           
=======================================
+ Hits        17390    17392    +2     
+ Misses       3647     3645    -2     

isaacwaldron
isaacwaldron previously approved these changes Dec 6, 2024
Copy link
Collaborator

@isaacwaldron isaacwaldron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@isaacwaldron
Copy link
Collaborator

@SMoraisAnsys looks good to me. Interesting that line 86 is covered, since you haven't modified any test to do this I'm surprised this could have been passing earlier as apparently there is a workflow that activates this code path.

@SMoraisAnsys
Copy link
Collaborator Author

@SMoraisAnsys looks good to me. Interesting that line 86 is covered, since you haven't modified any test to do this I'm surprised this could have been passing earlier as apparently there is a workflow that activates this code path.

It isn't covered by testing. I'll extend this PR with some tests on clr_module

@SMoraisAnsys SMoraisAnsys marked this pull request as draft December 6, 2024 12:08
@SMoraisAnsys SMoraisAnsys marked this pull request as ready for review December 6, 2024 16:22
@github-actions github-actions bot added the testing Anything related to testing label Dec 6, 2024
@SMoraisAnsys
Copy link
Collaborator Author

SMoraisAnsys commented Dec 6, 2024

Thanks for the review @isaacwaldron feel free to approve and I'll merge & make a new release this weekend so that you are no longer affected with this issue.

@isaacwaldron
Copy link
Collaborator

@SMoraisAnsys I had started a test run using a dependency to the initial commit (which has the actual change I need) on my downstream project that was failing. So far so good... will come back and finally approve when that passes.

Copy link
Collaborator

@isaacwaldron isaacwaldron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and passing in a downstream test suite that was previously failing. Thanks for the quick turnaround!

@SMoraisAnsys SMoraisAnsys merged commit 42e71aa into main Dec 7, 2024
29 checks passed
@SMoraisAnsys SMoraisAnsys deleted the fix/convert-dotnet-root-into-str branch December 7, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Anything related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants