-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Set DOTNET_ROOT with str and not Path #933
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #933 +/- ##
=======================================
Coverage 82.66% 82.67%
=======================================
Files 160 160
Lines 21037 21037
=======================================
+ Hits 17390 17392 +2
+ Misses 3647 3645 -2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@SMoraisAnsys looks good to me. Interesting that line 86 is covered, since you haven't modified any test to do this I'm surprised this could have been passing earlier as apparently there is a workflow that activates this code path. |
It isn't covered by testing. I'll extend this PR with some tests on clr_module |
Thanks for the review @isaacwaldron feel free to approve and I'll merge & make a new release this weekend so that you are no longer affected with this issue. |
@SMoraisAnsys I had started a test run using a dependency to the initial commit (which has the actual change I need) on my downstream project that was failing. So far so good... will come back and finally approve when that passes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and passing in a downstream test suite that was previously failing. Thanks for the quick turnaround!
As pointed out in https://github.com/ansys/pyedb/pull/924/files#r1870405256, the value that we are passing to
os.environ
is aPath
instance while it should bestr
. This solves this issue.@isaacwaldron I'll check that this works correctly when I get back from my trip and make a new release.